search

ANXS / postgresql

Fairly full featured Ansible role for Postgresql.
http://anxs.io/
MIT License
849 stars 573 forks source link

Fix #445: PSQL tasks fails when postgresql_port != 5432 (default value) #446

Closed lrk closed 4 years ago

lrk commented 4 years ago

I added PGPORT environment variable for each task using psql client where it need to connect to the database. I also change the postgresql_port in tests to check that everything work fine.

lrk commented 4 years ago

there is an error unrelated to my modification in CI tests for Python: 2.7 on fedora:27-builded image

fatal: [postgresql-9.5]: FAILED! => {"changed": false, "cmd": "dnf install -y python2-dnf", "failed": true, "msg": "Error: Unable to find a match: python2-dnf", "rc": 1, "stderr": "Error: Unable to find a match: python2-dnf\n", "stderr_lines": ["Error: Unable to find a match: python2-dnf"], "stdout": "Last metadata expiration check: 0:01:07 ago on Tue Sep  3 07:44:35 2019.\nNo match for argument: python2-dnf\n", "stdout_lines": ["Last metadata expiration check: 0:01:07 ago on Tue Sep  3 07:44:35 2019.", "No match for argument: python2-dnf"]}
fatal: [postgresql-11]: FAILED! => {"changed": false, "cmd": "dnf install -y python2-dnf", "failed": true, "msg": "Error: Unable to find a match: python2-dnf", "rc": 1, "stderr": "Error: Unable to find a match: python2-dnf\n", "stderr_lines": ["Error: Unable to find a match: python2-dnf"], "stdout": "Last metadata expiration check: 0:01:07 ago on Tue Sep  3 07:44:35 2019.\nNo match for argument: python2-dnf\n", "stdout_lines": ["Last metadata expiration check: 0:01:07 ago on Tue Sep  3 07:44:35 2019.", "No match for argument: python2-dnf"]}
fatal: [postgresql-10]: FAILED! => {"changed": false, "cmd": "dnf install -y python2-dnf", "failed": true, "msg": "Error: Unable to find a match: python2-dnf", "rc": 1, "stderr": "Error: Unable to find a match: python2-dnf\n", "stderr_lines": ["Error: Unable to find a match: python2-dnf"], "stdout": "Last metadata expiration check: 0:01:08 ago on Tue Sep  3 07:44:35 2019.\nNo match for argument: python2-dnf\n", "stdout_lines": ["Last metadata expiration check: 0:01:08 ago on Tue Sep  3 07:44:35 2019.", "No match for argument: python2-dnf"]}
fatal: [postgresql-9.6]: FAILED! => {"changed": false, "cmd": "dnf install -y python2-dnf", "failed": true, "msg": "Error: Unable to find a match: python2-dnf", "rc": 1, "stderr": "Error: Unable to find a match: python2-dnf\n", "stderr_lines": ["Error: Unable to find a match: python2-dnf"], "stdout": "Last metadata expiration check: 0:01:08 ago on Tue Sep  3 07:44:35 2019.\nNo match for argument: python2-dnf\n", "stdout_lines": ["Last metadata expiration check: 0:01:08 ago on Tue Sep  3 07:44:35 2019.", "No match for argument: python2-dnf"]}
fatal: [postgresql-9.4]: FAILED! => {"changed": false, "cmd": "dnf install -y python2-dnf", "failed": true, "msg": "Error: Unable to find a match: python2-dnf", "rc": 1, "stderr": "Error: Unable to find a match: python2-dnf\n", "stderr_lines": ["Error: Unable to find a match: python2-dnf"], "stdout": "Last metadata expiration check: 0:01:08 ago on Tue Sep  3 07:44:35 2019.\nNo match for argument: python2-dnf\n", "stdout_lines": ["Last metadata expiration check: 0:01:08 ago on Tue Sep  3 07:44:35 2019.", "No match for argument: python2-dnf"]}
lrk commented 4 years ago

i think it's related to the ansible dnf module requirements: https://docs.ansible.com/ansible/latest/modules/dnf_module.html#dnf-module

The below requirements are needed on the host that executes this module.

python >= 2.6
python-dnf
for the autoremove option you need dnf >= 2.0.1”

why not using the generic package module instead ?

gclough commented 4 years ago

Could you rebase this against master (with #447), as Fedora was killing the build

lrk commented 4 years ago

@gclough sorry i messed up my fork, so i re-create a new PR: #448