search

ANXS / postgresql

Fairly full featured Ansible role for Postgresql.
http://anxs.io/
MIT License
849 stars 573 forks source link

verbatim password_encryption #470

Closed barda closed 2 years ago

barda commented 4 years ago

For 11 copy password_encryption configuration variable: valid values are md5 and scram-sha-256

egmont1227 commented 4 years ago

duplicated by #460 and #368, i propose to close this one

maglub commented 4 years ago

PR #460 has a suboptimal solution:

password_encryption = {{ 'md5' if postgresql_password_encryption != 'scram-sha-256' else 'scram-sha-256' }}     # md5 or scram-sha-256

I agree with the solution in this PR, but this PR touches too many other things:

password_encryption = {{ postgresql_password_encryption if postgresql_password_encryption else 'off' }}     # md5 or scram-sha-256

Valid values are:

robustq commented 3 years ago

Can be closed as #460 was merged in, though @barda the privileges piece is interesting, and you should definitely consider moving those changes to another pull request

egmont1227 commented 3 years ago

Agree. Please adjust your changes to privileges only (merge master changes for password encryption) and rename this PR or close this one and open another one for the privileges part.

seems to be some kind of duplicate of #505 and #181 and related to Issue #175

gclough commented 2 years ago

@barda , thanks for the work, and based on the discussion above I will close this PR, but we would appreciate one specifically on the password fix.

If you can keep Pull Requests limited to only a single fix, then it makes them easier to approve/reject them individually.