ANXS / postgresql

Fairly full featured Ansible role for Postgresql.
http://anxs.io/
MIT License
848 stars 573 forks source link

Migrate from Travis CI to GitHub actions #511

Closed maglub closed 3 years ago

maglub commented 3 years ago

Hi,

This one obsoletes https://github.com/ANXS/postgresql/pull/510, as I have been continuing the Molecule implementation with:

image

gclough commented 3 years ago

Thanks for the work @maglub . The Travis pipeline still seems to run, and where can I see the Molecule CI tests?

image

maglub commented 3 years ago

I have pushed a delete of the .travis-ci.yml file, so it no longer runs in this pull request.

I just can't figure out how to make it run in a pull request in this repo. It works in my fork, in the github-actions branch.

https://github.com/maglub/postgresql/actions/runs/661254762

The molecule tests are found in the ./molecule directory in this pull request.

I will test a couple of more things.

maglub commented 3 years ago

I just tested on a separate repo that I set up here: https://github.com/maglub/actiontest/actions and could reproduce this behavior.

The empty project did not have a github actions configuration, only a README.md file. I forked the project, and added a .github/workflow/ci.yml, and created a pull reqeust.

Then went ahead and changed the test to do the following:

      - name: Simple test
        run: echo 2nd pull request

So I think we need to decide whether we want to migrate to Github Action (or do both Travis CI and Github Actions for a while).

I do not have an Ansible Galaxy notification (as we have in .travis-ci.yml) yet. I am not sure yet if

thbar commented 3 years ago

Just wanted to comment: superb work, it will help the role tremendously I believe! Thank you ❤️

maglub commented 3 years ago

I will merge this pull request later today, unless @gclough or @otakup0pe has any objections.