search

ANXS / postgresql

Fairly full featured Ansible role for Postgresql.
http://anxs.io/
MIT License
848 stars 571 forks source link

style: include spaces around all variables #573

Open gclough opened 3 months ago

gclough commented 3 months ago

@MrMegaNova , the pipeline seems to be breaking on debian12. I think it's unrelated to this PR, so any idea why?

TASK [Gathering Facts] *********************************************************
  fatal: [postgresql-13]: FAILED! => {"msg": "failed to transfer file /home/runner/.ansible/tmp/ansible-local-311737jo_bd0/tmpu3wbecvw to /tmp/.ansible-runner/tmp/ansible-tmp-171[154](https://github.com/ANXS/postgresql/actions/runs/8452288398/job/23152495560?pr=573#step:5:160)5116.2229574-3188-270162615485133/AnsiballZ_setup.py:\n\ndd: failed to open '/tmp/.ansible-runner/tmp/ansible-tmp-1711545116.2229574-3188-270162615485133/AnsiballZ_setup.py': No such file or directory\n"}
  fatal: [postgresql-16]: FAILED! => {"msg": "failed to transfer file /home/runner/.ansible/tmp/ansible-local-311737jo_bd0/tmp3hlnu5qv to /tmp/.ansible-runner/tmp/ansible-tmp-1711545116.2686648-3210-188811211754346/AnsiballZ_setup.py:\n\ndd: failed to open '/tmp/.ansible-runner/tmp/ansible-tmp-1711545116.2686648-3210-188811211754346/AnsiballZ_setup.py': No such file or directory\n"}
  fatal: [postgresql-14]: FAILED! => {"msg": "failed to transfer file /home/runner/.ansible/tmp/ansible-local-311737jo_bd0/tmpltqenivg to /tmp/.ansible-runner/tmp/ansible-tmp-1711545116.2045798-3189-118414509770377/AnsiballZ_setup.py:\n\ndd: failed to open '/tmp/.ansible-runner/tmp/ansible-tmp-1711545116.2045798-3189-118414509770377/AnsiballZ_setup.py': No such file or directory\n"}
  fatal: [postgresql-12]: FAILED! => {"msg": "failed to transfer file /home/runner/.ansible/tmp/ansible-local-311737jo_bd0/tmpxrsi7fah to /tmp/.ansible-runner/tmp/ansible-tmp-1711545116.2014093-3185-190524406011025/AnsiballZ_setup.py:\n\ndd: failed to open '/tmp/.ansible-runner/tmp/ansible-tmp-1711545116.2014093-3185-190524406011025/AnsiballZ_setup.py': No such file or directory\n"}
  fatal: [postgresql-15]: FAILED! => {"msg": "failed to transfer file /home/runner/.ansible/tmp/ansible-local-311737jo_bd0/tmpqu9425dq to /tmp/.ansible-runner/tmp/ansible-tmp-1711545116.2519045-3193-102489124427116/AnsiballZ_setup.py:\n\ndd: failed to open '/tmp/.ansible-runner/tmp/ansible-tmp-1711545116.2519045-3193-102489124427116/AnsiballZ_setup.py': No such file or directory\n"}
MrMegaNova commented 3 months ago

I have no idea, I've just retry the failed check, we'll see I have no time to debug today, I will take a look tomorrow or next week

Please do not push or request direct push to master anymore, fist create a PR to development then when development branch are stable merge into master

gclough commented 3 months ago

¯\_(ツ)_/¯, looks like it's running now.

OK, sounds good. Let me find the name of the dev branch and I'll re-jig this PR. It's only a cleanup, so nothing urgent.

MrMegaNova commented 3 months ago

Thanks for your work

gclough commented 3 months ago

Glad to help out @MrMegaNova, as I've been in your shoes... years ago when it was just me maintaining it. :-(

Also, can we change from master -> main at some point?

MrMegaNova commented 3 months ago

Glad to help out @MrMegaNova, as I've been in your shoes... years ago when it was just me maintaining it. :-(

Also, can we change from master -> main at some point?

Happy to see you back on this project, hoping our latest updates will bring back some maintainers on this project Great idea, maybe next week because it require some changes to rename the master branch into main. You can open an issue about this to keep it in mind.

github-actions[bot] commented 1 week ago

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!