Open bogdan799 opened 1 month ago
Why am I getting this email? Have you shared my email with an unknown third party which is a privacy violation?
Sent from my Galaxy
-------- Original message -------- From: bogdan799 @.> Date: 2024-10-17 8:30 p.m. (GMT-03:30) To: ANYCUBIC-3D/Kobra3 @.> Cc: Subscribed @.***> Subject: [ANYCUBIC-3D/Kobra3] Please explain the purpose to all of us interested (Issue #2)
First of all, I think it's huge work that had been done to rewrite software like the Klipper completely in a different language and technology for it to be able to run on cheaper hardware (probably) and to be faster and less prone to the sudden timer errors, for that as a software developer I give my big appreciation and respect.
However, I'm struggling to find a purpose in this repository to be existing in the first place, and let me explain why:
"We did a klipper in Go?"—cool, but it is limited in a few aspects. As far as I can tell, Pongo2 v5 is used for jinja syntax in Go, which doesn't support syntax in macro templates like printer["gcode_macro ABC"] in order to use some advanced macro. However, Pongo2 v6 supports that and was released in 2022, two years before the Kobra 3 release. If this is supposed to be a better and faster version of Klipper for anyone to admire (due to compiled code instead of Python), it should include all the features the original Klipper has, f.e. sdcard_loop, already mentioned advanced templating for gcode, and many more. Nevertheless, it seems this particular software was built with only Kobra 3 in mind due to the specific code, so I think even if we wanted that's not an option to use for a wide range of printers.
However, if it's meant to be just for the proud geek owners of Kobra 3 Combo to explore and extend, it seems you've stripped the Combo part here since there's no code for handling the filament hub communication and functionality. So if anyone figures out how to fix some things here and there for their custom gklib and also figures out how to install that firmware on their printer (for which you do not provide any steps), they might as well throw out ACE PRO directly through the open window, cause it'll be useless for the multicolor printing for the filament drying and auto-refill.
Warning: use at your own risk. If you install any custom firmware on your printer, it is very possible to damage your printer and you will forfeit your warranty support of some accessories. - you do say in your readme file... so please first provide some info on how to and full code, so it doesn't damage anything.
— Reply to this email directly, view it on GitHubhttps://github.com/ANYCUBIC-3D/Kobra3/issues/2, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BF4VOJFEILDGXLNGR6OYAYDZ4A6SJAVCNFSM6AAAAABQEX7AWGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU4TKOJTG43DMNI. You are receiving this because you are subscribed to this thread.Message ID: @.***>
@bogdan799 I must admit, I'm not familiar with the klipper code/architecture (yet), but I was digging through the codebase earlier and found:
Which seem to provide some of the ACE functionality you mentioned above
@detiber, well it only seems to be a part of some protocol that Is not used anywhere in the project itself. From other github repos we can get the idea of how the printer config looks like, it has [filament_hub] section for the ACE config including port and serial speed, so there should be some serial communication with the hub established at some place, also we should see FilamentHub class (according to the naming convention of the klipper each config section is handled by it's own class). However it doesn't exist here.
As for the instructions I meant how to install this firmware on the printer itself, and I can do it actually by a hack from https://github.com/systemik/Kobra3-Firmware repository which includes shell script and archive with some complicated password sent to the USB drive, however I don't see any other way and this repo doesn't include the instruction on how to actually install (replace gklib executable) on the non-rooted pristine 3d printer
First of all, I think it's huge work that had been done to rewrite software like the Klipper completely in a different language and technology for it to be able to run on cheaper hardware (probably) and to be faster and less prone to the sudden timer errors, for that as a software developer I give my big appreciation and respect.
However, I'm struggling to find a purpose in this repository to be existing in the first place, and let me explain why:
"We did a klipper in Go?"—cool, but it is limited in a few aspects. As far as I can tell, Pongo2 v5 is used for jinja syntax in Go, which doesn't support syntax in macro templates like printer["gcode_macro ABC"] in order to use some advanced macro. However, Pongo2 v6 supports that and was released in 2022, two years before the Kobra 3 release. If this is supposed to be a better and faster version of Klipper for anyone to admire (due to compiled code instead of Python), it should include all the features the original Klipper has, f.e. sdcard_loop, already mentioned advanced templating for gcode, and many more. Nevertheless, it seems this particular software was built with only Kobra 3 in mind due to the specific code, so I think even if we wanted that's not an option to use for a wide range of printers.
However, if it's meant to be just for the proud geek owners of Kobra 3 Combo to explore and extend, it seems you've stripped the Combo part here since there's no code for handling the filament hub communication and functionality. So if anyone figures out how to fix some things here and there for their custom gklib and also figures out how to install that firmware on their printer (for which you do not provide any steps), they might as well throw out ACE PRO directly through the open window, cause it'll be useless for the multicolor printing for the filament drying and auto-refill.
Warning: use at your own risk. If you install any custom firmware on your printer, it is very possible to damage your printer and you will forfeit your warranty support of some accessories. - you do say in your readme file... so please first provide some info on how to and full code, so it doesn't damage anything.