ANYbotics / grid_map

Universal grid map library for mobile robotic mapping

BSD 3-Clause "New" or "Revised" License

2.6k stars 798 forks source link

Fix Eigen Plugins compilation when linking to grid_map_core #475

Open Ryanf55 opened 2 months ago

Ryanf55 commented 2 months ago

Purpose

Here's a proposed patch for #382. Because the original PR for adding the plugins through CMake and ament is not well documented, I really don't know how this will affect others. Please try this PR out. It will stay open for a while until I get a reasonable number of approvals it doesn't break anything.

Test instructions

Check this branch out
colcon build --packages-up-to issue382

And try building your own packages that link to grid_map_core.

nhewitt99 commented 1 month ago

Just adding my $0.02 that this PR does fix the Eigen linker issues when using grid_map_core for me, thank you! I can't speak to its potential impact on other plugins, though.

Ryanf55 commented 1 month ago

Just adding my $0.02 that this PR does fix the Eigen linker issues when using grid_map_core for me, thank you! I can't speak to its potential impact on other plugins, though.

Thanks for sharing!