search

ANYbotics / kindr_ros

ROS wrappers for kindr
BSD 3-Clause "New" or "Revised" License
51 stars 49 forks source link

ROS2 support #22

Open AndreasAZiegler opened 5 years ago

AndreasAZiegler commented 5 years ago

Do you have plans to support ROS2 as well?

remod commented 4 years ago

Yes, we have. But I cannot promise any time frame :)

SivertHavso commented 3 years ago

I've had a go at porting kindr_ros and kindr_msgs (not including the rviz plugins) over at https://github.com/SivertHavso/kindr_ros/tree/ros2.

Two additional changes in my ROS2 port is that the VectorAtPosition message now starts with the header at the top, and tf2 is used instead of tf (deprecated).

If anyone has the ability to make a ros2 branch here and wants me to make a pull request upstream, give me a shout.

remod commented 3 years ago

Hi @SivertHavso !

As you probably imagined we have not transitioned to ROS2 yet as there were more imminent projects.

Thanks for your suggestion regarding the creation of a ROS2 branch! I think it is a great idea supporting the open source spirit :) Please go ahead and tag me on the PRs.

One remark: we will not be able to give support on the ROS2 branch, as we do not use it in production. We can take over merging updates though.

SivertHavso commented 2 years ago

(Got distracted with other projects for a while)

Hi @remod, seeing as https://github.com/ANYbotics/elevation_mapping could get ported to ROS2 soon (https://github.com/ANYbotics/elevation_mapping/issues/197) and it depends on this package, it might be a good idea to create a ROS2 branch now even if you can't support it yet.

remod commented 2 years ago

Done