search

ANYbotics / rqt_multiplot_plugin

An rqt plugin for visualizing numeric values in multiple 2D plots.
GNU Lesser General Public License v3.0
124 stars 42 forks source link

Arg parsing for the command line script #10

Closed stonier closed 7 years ago

stonier commented 7 years ago

This reflects the arguments already available in the c++ plugin code and makes them available via the python script.

Question...how did you test/use the c++ plugin command line arguments previously?

stonier commented 7 years ago

Brilliant plotting tool by the way....we had been discussing for the last month or two on doing a rewrite of rqt_plot here given how sorely sparse its feature set is. This more than fills the void.

stonier commented 7 years ago

Hold one sec, found a problem.

stonier commented 7 years ago

Dropped back to long arg forms...any kind of short arg format that doesn't conflict with rqt_gui would be kind of wierd and that suffices for me.

stonier commented 7 years ago

The global script was also previously unavailable in the devel workspace. The last commit in this PR uses the setup.py instead of the CMakelists.txt so we get it in the devel and install spaces.

samuelba commented 7 years ago

Thanks for your additions.

The multiplot-config parameter works, however, the multiplot-bag parameter does nothing. I think there is a line missing in MultiplotWidget.cpp -> void readBag(const QString& url) replacing the comment

//   ui_->bagReaderWidget->readBag(url);

with

ui_->plotTableWidget->loadFromBagFile(url);

seems to work, but I have to test a bit more.

To your first question, how we used these parameters before, I don't know.

stonier commented 7 years ago

I didn't actually test the bag loading, our initial use case was to be able to load configurations and I simply reflected the bag arguments through similarly since they were already in the c++.

Did just now, with the bugfix you provided above. It loaded, but I'm not exactly sure what's supposed to happen at this juncture. i.e. nothing happened, nor is it obvious what to do with the result.

Subsequently I've dropped the bag loading from the python script arg parsing. I'd be interested in finding out what the bag play is intended to do, but for now I think it's better keeping this PR focused on just the job of being able to load configurations.

samuelba commented 7 years ago

merged.