search

AOEpeople / Aoe_ClassPathCache

Class path cache for Magento autoloader
http://www.fabrizio-branca.de/magento-class-path-cache.html
Open Software License 3.0
49 stars 16 forks source link

Fixed AOEmedia/Aoe_ClassPathCache#10 #12

Closed Zyava closed 10 years ago

Zyava commented 11 years ago
Zyava commented 11 years ago

@fbrnc Added code for benchmarking in the separate branch: https://github.com/Zyava/Aoe_ClassPathCache/tree/permanent-cache-benchmarking

My benchmarking results on CE 1.7 & PHP 5.3.14: php ArrayObject_Int.php 1557384 B = 1.48524 MB php ArrayObject_String.php 1854816 B = 1.768890381 MB php Judy_Int.php
865600 B = 0.825500488 MB php Judy_String.php 865616 B = 0.825515747 MB

So, even in the worst case it won't eat more than 2 MB. On EE plus many custom extensions ti might be around 3-4 MB. Not so much nowadays. With Judy it needs 2 times less memory.

Zyava commented 11 years ago

@fbrnc any input from your side? @colinmollenhour since you are active user of this extension, maybe you have some concerns against this approach?

colinmollenhour commented 11 years ago

I think I am OK with a one-time cache generation now that it gets revalidated rather than cleared so probably wouldn't use this feature esp given the memory trade off.

If anything you should search only the php include paths, not the entire root. Also there is a lot in lib which never gets used so maybe only app/code.

LeeSaferite commented 10 years ago

This pull request no longer cleanly merges. Please resolve this and issue a new pull request. I will merge the request ASAP so it will not get too old again.

Also, please do not include pure formatting changes in a pull request unless the pull request is specifically for reformatting.