search

AOEpeople / Aoe_LazyCatalogImages

Magento module to lazy render catalog images
Open Software License 3.0
71 stars 14 forks source link

Added support of constrainOnly flag #16

Closed ihor-sviziev closed 7 years ago

ihor-sviziev commented 7 years ago

constrainOnly method doing following: Guarantee, that image picture will not be bigger, than it was. Applicable before calling resize() It is false by default

ihor-sviziev commented 7 years ago

@LeeSaferite could you review this PR?

ihor-sviziev commented 7 years ago

@LeeSaferite Could you merge these changes & add new release for that?

ihor-sviziev commented 7 years ago

@drobinson could you create release tag with these changes?

drobinson commented 7 years ago

Sure here you go - sorry for the delay https://github.com/AOEpeople/Aoe_LazyCatalogImages/releases/tag/1.0.2

LeeSaferite commented 7 years ago

@drobinson You tagged the code, but didn't update the package version in the config XML.

drobinson commented 7 years ago

@LeeSaferite DARN, well I'm not sure it's worth creating a new tag/updating this one just to keep the config.xml in sync with the release version, especially if there weren't any setup scripts included...thoughts?

LeeSaferite commented 7 years ago

It's fine. Just something to be aware of for the future.