search

AOEpeople / Aoe_TemplateHints

Advanced Template Hints for Magento
http://www.fabrizio-branca.de/magento-advanced-template-hints-20.html
GNU General Public License v3.0
189 stars 66 forks source link

Invisible Template Hints #2

Closed amenk closed 11 years ago

amenk commented 12 years ago

Most developers have the source code view on most of the time anyways so I think another way of template hinting would be to just display HTML comments

can such an option be added?

fbrnc commented 12 years ago

Hi Alexander,

I like the idea, but: Are devs acutally using the source code view over tools like Firebug to inspect the source code? Firebug won't show those HTML comments, will it?

I could add a configuration option to choose whether the info should be rendered as poups, in title-tags or as HTML comments.

amenk commented 12 years ago

Devs use Chrome nowadays :-)

But I checked it - Firebug source code view hides the HTML comments. The Chrome dev tools show them.

fbrnc commented 12 years ago

I created a branch "comments" to experiment with this. Actually I like it a lot, and it works fine in checking the comments in the source code view in chrome. I will add a configuration parameter to choose how the comments should be rendered and merge both ways into a single branch.

amenk commented 11 years ago

I like it a lot. Should we merge it into master? and have a configuration option to switch it? or switch it via ath=comments in the URL param?

fbrnc commented 11 years ago

I'd like to do both: Adding a configuration option and also parsing the ath parameter to override the configuration in case something else than "1" is used.

amenk commented 11 years ago

Yes! +1 Just tried out the visual template hints to check the click-to-open-in-PHPstorm but was not satisfied. It's in a legacy shop with bad CSS and the template hinting destroys a lot of the layout - so invisible template hints are the way to go here.

fbrnc commented 11 years ago

Hi, this is already implemented and in the main branch (sorry for not cleaning up this issue). Check the module's settings and choose "comments" there instead of "popup". Let me know if you run into problems. The click-to-open-in-phpstorm obviously doesn't make much sense if the you're running the comments mode.

amenk commented 11 years ago

Great - tried the click any open and it is so nice!