Use Selfupdate Commands Or Always Get Latest Version

AOEpeople / MageTestStand

GNU General Public License v3.0

59 stars 30 forks source link

Open sprankhub opened 7 years ago

sprankhub commented 7 years ago

What do you think of adding the following selfupdate commands to the setup.sh after the git clone?

${BUILDENV}/tools/n98-magerun.phar self-update
${BUILDENV}/tools/composer self-update

Another idea would be to always download the latest version and not keeping it in the repo at all...

bastianccm commented 7 years ago

self-update can fail, which is bad for CI. Rather have a pinned tool here, which you can also use while working offline, github down, etc. etc.

sprankhub commented 7 years ago

Not sure if this is a valid concern since the setup is based on composer, which can also easily fail...