AOEpeople / TYPO3_Restler

restler (PHP REST-Framework) for TYPO3
GNU General Public License v3.0
30 stars 17 forks source link

fixed no matches when working with PageTypeSuffix #41

Closed develth closed 5 years ago

develth commented 5 years ago

When using PageTypeSuffix and e.g. the default setting for '.html', the empty return value leads to an error when requesting 'normal' pages.

tomasnorre commented 5 years ago

HI @develth

Could you please check the typo3v9 branch instead? and rebase and PR against that..

develth commented 5 years ago

Hi @tomasnorre ok - but in this branch the last commit was 28 days ago, also with the commits that fixes the v9 routing that are not in branch typo3v9 (last commit in january).

tomasnorre commented 5 years ago

Sorry.. My mind was in a different extension. My bad, sorry for the confusion, I'll just say out of it.

@StefanMasz and @sven-carstens are the goto persons here.

StefanMasz commented 5 years ago

merged

Please notice that this is a ongoing development branch. Due to the new approach with psr-middleware in v9, it will take some time before we "release" this branch.

sven-carstens commented 5 years ago

But we are already running it in production for a couple of monthes. If anything is missing to get your use case working, just gives us a call or try to resolve it for yourself first during https://hacktoberfest.digitalocean.com/ 2019

sven-carstens commented 4 years ago

The regexp '.$' broke our systems. The page '/datenschutz' becomes unreachable for instance. I changed it to match any extension '.[^.]+$'. @develth Could you try out if that also works for you?

develth commented 4 years ago

@sven-carstens your change still works with my Suffix default: '.html'. But if i change it to default: '' and trying to call e.g. /datenschutz it still fails.

sven-carstens commented 4 years ago

You are using the PageTypeSuffix RouteEnhancer for setting the '.html' ?

develth commented 4 years ago

Yes