AOEpeople / aoe_technology_radar

Create your own Technology Radar: A static site generator for a full featured Technology Radar. Features: Quadrants, Rings, Dashboard, Radar Visualization, Item History, Search etc..
http://www.aoe.com/techradar
Other
262 stars 121 forks source link

v4: sitemap.xml missing #438

Closed DanielRuf closed 5 months ago

DanielRuf commented 6 months ago

With the new Next setup, there is no sitemap.xml file generated.

See https://nextjs.org/docs/app/api-reference/file-conventions/metadata/sitemap#generating-a-sitemap-using-code-js-ts for context.

mathiasschopmans commented 6 months ago

I'm not sure of the value of having a sitemap.xml. Google says you might not need an XML sitemap if:

https://builtin.com/marketing/sitemap-xml-overrated

The v3 implementation did not align to the sitemap.xml spec, as it created relative URLs.

<loc>: URL of the page. This URL must begin with the protocol (such as http) and end with a trailing slash, if your web server requires it. This value must be less than 2,048 characters.

https://www.sitemaps.org/protocol.html#locdef

ℹ️ To generate a valid sitemap.xml, we need to introduce a new setting: config.baseUrl.

mathiasschopmans commented 6 months ago

I created a PR. Does this meet your expectation, @DanielRuf?