AOEpeople / geb-spock-reports

Integrates Geb screenshots into the spock-reports library
Apache License 2.0
36 stars 11 forks source link

Add project name, version and added skipped scenario functionality #14

Closed trinidad8516 closed 6 years ago

trinidad8516 commented 6 years ago

Added Skipped test scenarios and functionality to the summary template file and project name and version.

tilmanginzel commented 6 years ago

Hey @trinidad8516, thanks for the pull request! These are nice improvements, I will test and merge them in the coming days and release a new version. :)

Do we need the com.energizedwork.idea-* gradle plugins?

trinidad8516 commented 6 years ago

Hey @tilmanginzel, May be not the .idea ones let me test them and look at the documentation for the plugin.

trinidad8516 commented 6 years ago

@tilmanginzel I made the changes and I did more testing please feel free to test and review some more.

tilmanginzel commented 6 years ago

Hi @trinidad8516, thanks! :)

I have just a few minor change requests:

  1. I would remove the <em>, as this results in too many different styles in one line. Italic text is also used nowhere else in the templates.
  2. The text color in the skipped rows could be shown in a light gray.
  3. I would prefer it if the projectName and version are on the right to the creation date, not on the left. This would align it with the creation date on the specification template, e.g.: grafik

The third one turns out to be more complicated to implement. The comma , becomes part of the next (optional) element. And for some reason the templating engine always adds a whitespace between outputs, which does not look so nice. Using the out << syntax, it seems to kinda work:

<span class="date-test-ran">
<%
    out << "Created on ${new Date()} by ${System.properties['user.name']}"
    out << (projectName ? ', <strong>Project: </strong> ' + projectName : '')
    out << (projectVersion ? (', <strong>Version: </strong>' + projectVersion) : '')
%>
</span>

What do you think? It seems a bit hacky, but I don't know if there's a simpler solution. If you don't have time to add the changes above, I can do it of course. My time is limited today, but I should have more time tomorrow.

Cheers!

trinidad8516 commented 6 years ago

Sure that works, I’ll send the changes

trinidad8516 commented 6 years ago

@tilmanginzel I made the changes that you suggested.

trinidad8516 commented 6 years ago

@tilmanginzel I found a little bug, I am going to fix it and also add a scenario.

tilmanginzel commented 6 years ago

Perfect, thank you! 👍 If you want and the bug is not related to these changes, I could already merge them.

trinidad8516 commented 6 years ago

@tilmanginzel fixed, please merge when you can!

tilmanginzel commented 6 years ago

Hi @trinidad8516, I have added another small commit, I hope you don't mind :)

The commits have been merged. Thanks again for the effort! 👍 I will release a new version 0.2.1 as soon as possible.

tilmanginzel commented 6 years ago

I just published version v0.2.1 with all the changes. :)