Closed trinidad8516 closed 6 years ago
Hey @trinidad8516, thanks for the pull request! These are nice improvements, I will test and merge them in the coming days and release a new version. :)
Do we need the com.energizedwork.idea-*
gradle plugins?
Hey @tilmanginzel, May be not the .idea ones let me test them and look at the documentation for the plugin.
@tilmanginzel I made the changes and I did more testing please feel free to test and review some more.
Hi @trinidad8516, thanks! :)
I have just a few minor change requests:
<em>
, as this results in too many different styles in one line. Italic text is also used nowhere else in the templates.The third one turns out to be more complicated to implement. The comma ,
becomes part of the next (optional) element. And for some reason the templating engine always adds a whitespace between outputs, which does not look so nice. Using the out <<
syntax, it seems to kinda work:
<span class="date-test-ran">
<%
out << "Created on ${new Date()} by ${System.properties['user.name']}"
out << (projectName ? ', <strong>Project: </strong> ' + projectName : '')
out << (projectVersion ? (', <strong>Version: </strong>' + projectVersion) : '')
%>
</span>
What do you think? It seems a bit hacky, but I don't know if there's a simpler solution. If you don't have time to add the changes above, I can do it of course. My time is limited today, but I should have more time tomorrow.
Cheers!
Sure that works, I’ll send the changes
@tilmanginzel I made the changes that you suggested.
@tilmanginzel I found a little bug, I am going to fix it and also add a scenario.
Perfect, thank you! 👍 If you want and the bug is not related to these changes, I could already merge them.
@tilmanginzel fixed, please merge when you can!
Hi @trinidad8516, I have added another small commit, I hope you don't mind :)
The commits have been merged. Thanks again for the effort! 👍 I will release a new version 0.2.1 as soon as possible.
I just published version v0.2.1 with all the changes. :)
Added Skipped test scenarios and functionality to the summary template file and project name and version.