search

AOEpeople / geb-spock-reports

Integrates Geb screenshots into the spock-reports library
Apache License 2.0
36 stars 11 forks source link

File separator has to be escaped for Windows environmnent #2

Closed lubosek closed 7 years ago

lubosek commented 7 years ago

Otherwise following failure is observed:

java.util.regex.PatternSyntaxException: Unexpected internal error near index 1
\
 ^

at com.aoe.gebspockreports.GebReportUtils.createSpecLabelFromPath(GebReportUtils.groovy:80)
at com.aoe.gebspockreports.GebReportingListener.onReport(GebReportingListener.groovy:40)
tilmanginzel commented 7 years ago

Hey @lubosek,

thanks for the pull request! I will try to test the change in the coming week and will get back to you afterwards.

lubosek commented 7 years ago

OK, thanks, if it would of any help there's patched jar here: https://github.com/lubosek/geb-spock-reports/tree/repository/com/aoe/geb-spock-reports/0.2.0-dev.1%2B2600238 It can be used simply by configuring a new repo (yep, I'm still Maven guy, sorry ;-) ):

        <repository>
            <url>https://raw.githubusercontent.com/lubosek/geb-spock-reports/repository/</url>
            <id>github</id>
            <name>github</name>
            <snapshots>
                <enabled>false</enabled>
            </snapshots>
        </repository>
tilmanginzel commented 7 years ago

@lubosek I just published version 0.1.3 with your fix, thank you!