search

AOEpeople / geb-spock-reports

Integrates Geb screenshots into the spock-reports library
Apache License 2.0
36 stars 11 forks source link

Images not Embedding when extending GebSpec #31

Closed seanfrenzel closed 3 years ago

seanfrenzel commented 3 years ago

As described reports will not be embedded when only extending GebSpec and need to extend GebReportingSpec to embed screenshots. This isn't documented on renatoathaydes project or this one and I had to troubleshoot to come to that conclusion.

Please add the relevant documentation to express this requirement.

edit: removed irrelevant information with previously thought issues but feel free to comb through the edit history :)

tilmanginzel commented 3 years ago

Hi @seanfrenzel, thanks for the issue, that is a very good point I haven't thought about yet! I will update the readme in the coming days.

tilmanginzel commented 3 years ago

@seanfrenzel I have updated the readme accordingly. :) I am going to close this issue, but if you think that the explanation can be improved, feel free to reopen it!