Inverted diff when overriding code in local codepool?

[real34]

It seems that diff is inverted in the Code Pool Override Report (- instead of +). I wanted to check whether it was a bug or a feature and if you think it should be fixed I'll work on a patch.

To reproduce

• create a file in app/code/local/Mage/Adminhtml/Block/Promo/Quote/Edit/Tab/Actions.php of a Magento application
• comment the line Mage::dispatchEvent('adminhtml_block_salesrule_actions_prepareform', array('form' => $form)); (~ L159)
• Install the latest version (master branch - 2062e4dd1190dedab0b2ffd4a1067928da8192f3)
• run n98-magerun mpmd:codepooloverrides foo.html

  What happens

The "Changed files (differentFileContent)" of the "Comparing local and core" section contains the following diff for /Mage/Adminhtml/Block/Promo/Quote/Edit/Tab/Actions.php:

--- /path/to/app/code/local/Mage/Adminhtml/Block/Promo/Quote/Edit/Tab/Actions.php   2012-01-20 00:00:00.000000000 +0100
+++ /path/to/app/code/core/Mage/Adminhtml/Block/Promo/Quote/Edit/Tab/Actions.php    2012-01-09 00:00:00.000000000 +0100
@@ -159,7 +159,7 @@
             'required' => true,
         ))->setRule($model)->setRenderer(Mage::getBlockSingleton('rule/actions'));

-        //Mage::dispatchEvent('adminhtml_block_salesrule_actions_prepareform', array('form' => $form));
+        Mage::dispatchEvent('adminhtml_block_salesrule_actions_prepareform', array('form' => $form));

         $form->setValues($model->getData());

Expected

For more consistency with Core Hacks Report, the diff should read:

--- /path/to/app/code/core/Mage/Adminhtml/Block/Promo/Quote/Edit/Tab/Actions.php    2012-01-09 00:00:00.000000000 +0100
+++ /path/to/app/code/local/Mage/Adminhtml/Block/Promo/Quote/Edit/Tab/Actions.php   2012-01-20 00:00:00.000000000 +0100
@@ -159,7 +159,7 @@
             'required' => true,
         ))->setRule($model)->setRenderer(Mage::getBlockSingleton('rule/actions'));

-        Mage::dispatchEvent('adminhtml_block_salesrule_actions_prepareform', array('form' => $form)); 
+        //Mage::dispatchEvent('adminhtml_block_salesrule_actions_prepareform', array('form' => $form));

         $form->setValues($model->getData());

What do you think?

[real34]

Any thoughts?

[schmengler]

+1 this confused me as well

[tmotyl]

Hi @real34, can you provide a pull request fixing this issue?

[hannes011]

+1