AOMediaCodec / afgs1-spec

Film grain synthesis algorithm and parameters
https://aomediacodec.github.io/afgs1-spec/
Other
8 stars 7 forks source link

Offset AR coefficients to get the AV1 range #116

Open andrey-norkin opened 6 months ago

andrey-norkin commented 6 months ago

Shift AR parameters to get them to AV1 range. An alternative would be to not subtract 128 in the film grain synthesis algorithm, but this would make the implementation slightly different from AV1.

haasn commented 6 months ago

An alternative would be to not subtract 128 in the film grain synthesis algorithm, but this would make the implementation slightly different from AV1.

Strongly disapprove of deviating the synthesis implementation, so adding the +128 here seems like the best solution to me. Implementers in practice will know to skip the redundant addition/subtraction anyway.