search

AOMediaCodec / afgs1-spec

Film grain synthesis algorithm and parameters
https://aomediacodec.github.io/afgs1-spec/
Other
8 stars 7 forks source link

On the placement of the FGS metadata in the elementary stream #28

Closed podborski closed 10 months ago

podborski commented 11 months ago

Maybe I missed this but I didn't see any details on the placement of the FGS metadata OBU and on the number of FGS metadata OBUs.

Is it present just once in a temporal unit? Does it come after the frame header OBU or before it? What if there are multiple frames with show_frame=0 in a single TU? and so on.

podborski commented 11 months ago

apply_grain equal to 1 specifies that film grain should be added to this frame. apply_grain equal to 0 specifies that film grain should not be added.

What is this frame?

It seems like we need some language to clarify what this frame is perhaps by mentioning that a frame is associated to the FGS metadata or something like that.

andrey-norkin commented 10 months ago

This was discussed, and it was agreed that the current specification should be silent on that. Instead, this should be defined by an elementary bitstream, in which this metadata is included.