search

AOMediaCodec / afgs1-spec

Film grain synthesis algorithm and parameters
https://aomediacodec.github.io/afgs1-spec/
Other
8 stars 7 forks source link

Cicp signaling #43

Closed asegallamz closed 8 months ago

asegallamz commented 8 months ago

Thanks. Looks like we need an “and” before “(ix) video_full_range_flag equal to the…”.

From: Andrey Norkin @.> Reply-To: AOMediaCodec/afgs1-spec @.> Date: Tuesday, January 2, 2024 at 8:41 PM To: AOMediaCodec/afgs1-spec @.> Cc: "Segall, Andrew" @.>, Author @.***> Subject: Re: [AOMediaCodec/afgs1-spec] Cicp signaling (PR #43)

@andrey-norkin approved this pull request.

LGTM, also made a fix for matching the decoded picture parameters match.

— Reply to this email directly, view it on GitHubhttps://github.com/AOMediaCodec/afgs1-spec/pull/43#pullrequestreview-1801372455, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BDQ33XOAKI4AZE2CBXH4HQDYMTOOJAVCNFSM6AAAAABAURBOXKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMBRGM3TENBVGU. You are receiving this because you authored the thread.Message ID: @.***>

andrey-norkin commented 8 months ago

Thanks. Looks like we need an “and” before “(ix) video_full_range_flag equal to the…”. From: Andrey Norkin @.> Reply-To: AOMediaCodec/afgs1-spec @.> Date: Tuesday, January 2, 2024 at 8:41 PM To: AOMediaCodec/afgs1-spec @.> Cc: "Segall, Andrew" @.>, Author @.> Subject: Re: [AOMediaCodec/afgs1-spec] Cicp signaling (PR #43) @andrey-norkin approved this pull request. LGTM, also made a fix for matching the decoded picture parameters match. — Reply to this email directly, view it on GitHub<#43 (review)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BDQ33XOAKI4AZE2CBXH4HQDYMTOOJAVCNFSM6AAAAABAURBOXKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMBRGM3TENBVGU. You are receiving this because you authored the thread.Message ID: @.>

Agree. I will add "and" to the next PR.