search

AOMediaCodec / afgs1-spec

Film grain synthesis algorithm and parameters
https://aomediacodec.github.io/afgs1-spec/
Other
8 stars 7 forks source link

T35 metadata syntax #48

Closed podborski closed 8 months ago

podborski commented 9 months ago

close #22 close #24

podborski commented 8 months ago

The majority of this PR was already added to #19. The only remaining part is this note:

Note: This specification exclusively defines the value of the itu_t_t35_terminal_provider_oriented_code for identifying AV1 film grain parameters metadata. Additionally, it is important to note that the itu_t_t35_terminal_provider_oriented_code in the AOMedia context utilizes a one-byte code space. Within this range, specific values are reserved for future extensions. While this specification does not encompass the extension mechanism or the complete syntax of metadata_aom_itut_t35( ), these aspects, along with a comprehensive list of values for the AOMedia itu_t_t35_terminal_provider_oriented_code, will be detailed in the AOMedia metadata registry specification.

Since we agreed to remove the reference to the unfinished AOMedia metadata registry. I propose to update this note to:

Note: This specification exclusively defines the value of the itu_t_t35_terminal_provider_oriented_code for identifying AV1 film grain parameters metadata. Additionally, it is important to note that the itu_t_t35_terminal_provider_oriented_code in the AOMedia context utilizes a one-byte code space, within which specific values can be reserved for future extensions.

@andrey-norkin @alexismt73 @asegallamz what do you think guys? If we are ok with this updated note, we can just add it to #19 and close this PR. If you think this note is not useful, just close this PR.

andrey-norkin commented 8 months ago

The changes from this PR were addressed in #19