AOMediaCodec / afgs1-spec

Film grain synthesis algorithm and parameters
https://aomediacodec.github.io/afgs1-spec/
Other
8 stars 7 forks source link

Signaling of *_mult, *_luma_mult and *_offset are unclear. #90

Closed asegallamz closed 10 months ago

asegallamz commented 10 months ago

Semantics state that:

If predict_cr_scaling_flag is equal to 1, the variables cr_mult, cr_luma_mult, and cr_offset are set equal to the variables cr_mult, cr_luma_mult, and cr_offset in the film grain parameter set indicated by film_grain_param_set_idx equal to film_grain_param_set_idx_for_prediction.

However, the syntax table is unclear and suggests these values are present in the bit-stream.

Same comment applies for cb_mult, cr_luma_mult, cr_offst.