search

AOMediaCodec / av1-avif

AV1 Image File Format Specification - ISO-BMFF/HEIF derivative
https://aomediacodec.github.io/av1-avif/
BSD 2-Clause "Simplified" License
450 stars 40 forks source link

Update multi-layer content to conform to new 'lsel' wording #181

Open leo-barnes opened 2 years ago

leo-barnes commented 2 years ago

Once #180 lands, we need to update the test content to conform to the new wording.

leo-barnes commented 2 years ago

Re-opening this to track updating the Xiph content.

@tdaede: Do you have some time to update the Xiph multilayer content to the latest wording in the spec? If not, I can try doing it manually, but if you have some easy way to do it that will most likely be faster.

tdaede commented 2 years ago

@leo-barnes ah indeed I still have the scripts to do this. I need to double check that the current GPAC implementation is correct bu tthen I can rerun them and PR some new images.

wantehchang commented 2 years ago

@tdaede Please also update the a1lx boxes in your test images to the definition in v1.1.0. The problem is that the layer_size array should contain the sizes of the layers themselves, not the cumulative sizes.

tdaede commented 2 years ago

Oh whoops, I thought this was about the layer_size array.

For lsel, could you clarify on what needs updating? Do you want additional files that contain a 0xFFFF lsel? AFAIK the ones that exist are still valid according to the new wording?

wantehchang commented 2 years ago

Thomas: We don't need additional files. We need to make sure all the existing layered images contain an lsel box. If a layered image doesn't have an 'lsel' box, please add a 0xFFFF lsel.

This is to conform to HEIF, which says an lsel box is mandatory for layered images.