search

AOMediaCodec / av1-avif

AV1 Image File Format Specification - ISO-BMFF/HEIF derivative
https://aomediacodec.github.io/av1-avif/
BSD 2-Clause "Simplified" License
450 stars 40 forks source link

Fix "anchor defined with local link" Bikeshed err #205

Closed y-guyon closed 1 year ago

y-guyon commented 1 year ago

Fix FATAL ERROR: <pre class=anchors> anchor was defined with a local link '#biblio-heif'. Please use urlPrefix and/or url to define an external URL.

(update)

:boom: Error: 400 Bad Request :boom:

PR Preview failed to build. (Last tried on Nov 23, 2022, 4:30 AM UTC).

More PR Preview relies on a number of web services to run. There seems to be an issue with the following one: :rotating_light: [CSS Spec Preprocessor](https://api.csswg.org/bikeshed/) - CSS Spec Preprocessor is the web service used to build Bikeshed specs. :link: [Related URL](https://api.csswg.org/bikeshed/?url=https%3A%2F%2Fraw.githubusercontent.com%2FAOMediaCodec%2Fav1-avif%2Fbde4abda08b7934e7b78da2de4d1f7b1157f4548%2Findex.bs&md-warning=not%20ready) ``` Error running preprocessor, returned code: 2. FATAL ERROR: <pre class=anchors> anchor was defined with a local link '#biblio-heif'. Please use urlPrefix and/or url to define an external URL. ✘ Did not generate, due to fatal errors ``` _If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please [file an issue](https://github.com/tobie/pr-preview/issues/new?title=Error%20not%20surfaced%20properly&body=See%20AOMediaCodec/av1-avif%23205.)._
y-guyon commented 1 year ago

I do not understand why PR Preview is failing. The commit works locally. I believe PR Preview does not pick the commit changes but runs at head instead.

cconcolato commented 1 year ago

I do not understand why PR Preview is failing. The commit works locally. I believe PR Preview does not pick the commit changes but runs at head instead.

It's due to the fact that you use a version that is not the same as PR preview. PR Preview uses the latest Bikeshed and it contains non-backwards compatible changes in the way anchors are treated in the bibliography, see https://github.com/tabatkins/bikeshed/issues/2363

cconcolato commented 1 year ago

Actually, your changes should be fixing the problem. I don't understand what happens to PR Preview ...

cconcolato commented 1 year ago

Trying this URL https://raw.githubusercontent.com/AOMediaCodec/av1-avif/bde4abda08b7934e7b78da2de4d1f7b1157f4548/index.bs (which is what "Related URL" points to) in https://api.csswg.org/bikeshed/ gives the same failure.

cconcolato commented 1 year ago

Using this URL https://raw.githubusercontent.com/AOMediaCodec/av1-avif/6db6de2c2169d63bad89613ada90c1f9575a84f4/index.bs which is the RAW URL for the file in this PR in https://api.csswg.org/bikeshed/ does work. It looks like PR Preview is not picking the correct URL.

y-guyon commented 1 year ago

It may be related to the fact that I am a first-time contributor. See https://github.com/AOMediaCodec/av1-avif/pull/209 where running the workflow needs approval.