search

AOMediaCodec / av1-avif

AV1 Image File Format Specification - ISO-BMFF/HEIF derivative
https://aomediacodec.github.io/av1-avif/
BSD 2-Clause "Simplified" License
450 stars 40 forks source link

Add pull_request to auto-publish.yml #209

Closed y-guyon closed 1 year ago

wantehchang commented 1 year ago

Yannis: I saw an "Approve and run" button and I clicked it.

y-guyon commented 1 year ago

Could someone merge this https://github.com/AOMediaCodec/av1-avif/pull/209 and https://github.com/AOMediaCodec/av1-avif/pull/205, or approve them and give me write access? Or should I regroup them in a single PR?

cconcolato commented 1 year ago

I'm not sure I understand why we need to add pull_request to auto-publish.yml? When I compare the settings of this repo with the AV1-ISOBMFF repo, they are identical and PR in AV1-ISOBMFF get preview and diff.

y-guyon commented 1 year ago

I'm not sure I understand why we need to add pull_request to auto-publish.yml? When I compare the settings of this repo with the AV1-ISOBMFF repo, they are identical and PR in AV1-ISOBMFF get preview and diff.

It seems to replace the Preview | Diff feature by a standard GitHub workflow check. The check is more consistent with usual GitHub presubmit tests, but I do no longer see any link to the generated HTML, so this is worse.