Closed trevorknight closed 5 months ago
1) Looks like a risk of buffer overrun in iamf2bear
if neither __linux__
or _WIN32
are defined.
I think if we are using this style it may be better to check all three everywhere it is being used. Use ||
when it makes sense.
I have seen some build systems that check for the presence of a header and create some kind of HAS_XX_H
define that can be used as well. I'm not sure of the best practice here though.
When building Wasm, none of those are by default defined, so would be nice to have defaults.
Thanks, it is good job.
iamf_bear_api.h explicitly has three options: linux, APPLE, _WIN32:
vlogging_tool_sr.c assumes Windows if not linux or APPLE:
iamf2bear.cpp only supports linux or _WIN32: