search

AOSC-Archive / autobuild3

AOSC OS package maintenance toolkit (version 3)
https://aosc.io
GNU General Public License v2.0
24 stars 17 forks source link

mipsel: switch to n64 abi #101

Closed FlyGoat closed 6 years ago

FlyGoat commented 6 years ago

mipsel: switch to n64 abi

FlyGoat commented 6 years ago

After discussion, we decided to set MIPS-III N64 ABI as mips64el mips64el-aosc-linux-gnu, and MIPS64r2 N64 ABI as mips64r2el mipsisa64r2el-aosc-linux-gnu.

jyhi commented 6 years ago

Developers:

At this time please do not merge, to allow our thorough research on these changes.

Artoria2e5 commented 6 years ago

yo merge #102 into your thing

Artoria2e5 commented 6 years ago

pkgprovide exists. you can have a new proc or acbs wrap handle this overlay shit. maybe work it into the new arch system to-do too. it's not like we haven't talk about having many architecture-libs for amd64 with some libpath work.

MingcongBai commented 6 years ago

@Artoria2e5 The overlay system utilises repositories, not so much on a packaging level, the triplet wouldn't change, only the flags.

Aside: please keep it civilised. As fun as it is to speak your true mind, it is much easier to engage in a technical conversation when we could all speak respectfully.

FlyGoat commented 6 years ago

101 Now at least MIPS64r2EL works.

Requst for some review. I'm going to merge it later.

jyhi commented 6 years ago

I'm going to merge it later.

Not now.

Artoria2e5 commented 6 years ago

I have no idea about what I am reading right now, and I don't think you should ask me for a review.

jyhi commented 6 years ago

and I don't think you should ask me for a review.

Whether the code quality is good or not.

MingcongBai commented 6 years ago

Looks good to me for the most part. Though mind the alignment in case mips64) from ab3_defcfg.sh.

MingcongBai commented 6 years ago

@FlyGoat Please respond to some of the review questions above...

FlyGoat commented 6 years ago

@MingcongBai ok I'm going to fix it tomorrow.(strange behavior of vscode....

FlyGoat commented 6 years ago

Pushed to staging manually.

jyhi commented 6 years ago

@FlyGoat Do you really know what are you doing?

jyhi commented 6 years ago

You should really care about people's opinions, since you are not working on a personal project.

In eb5d8ae you did add code to support mipsisa64r2el, but you 1) did not respond to questions above, 2) bypassed this PR, rendering workflow messy.

You should think about it. This PR does not fully solve the issue, reopening.

FlyGoat commented 6 years ago

@lmy441900 my fault.... Just trying to find out a method to separate changes between mips64el and mips64r2el since origin commits mixed them together.

FlyGoat commented 6 years ago

@lmy441900 Should I create another pr for mips64el or continue this PR?

jyhi commented 6 years ago

And now we can see conflicts.

You do great on porting AOSC OS to MIPS (Loongson) platforms. You've made a leap. But think about quality of code. Your production should be easy for other people to maintain (understand).

You can of course continue to push to staging, but please leave this PR open as an issue to keep track of the status of support.

FlyGoat commented 6 years ago

@lmy441900 Thanks for your suggestions. The next step should be rework abdetectarch. Do you have any idea about that?

MingcongBai commented 6 years ago

@FlyGoat Please limit your work to what this PR is about. What we needed to do here is to add an architectural support, no more, no less. If a function (related or not) needs rework, please open up another PR - this PR is big enough as is...