AB_FLAGS_XXX do not work in defines

[Icenowy]

as the title says test case is extra-libs/js-24

[MingcongBai]

This issue is most possibly introduced by the faulty fix for #64. I will assign myself on this.

[Artoria2e5]

As mentioned in IRC, flag-dependent decisions in arch/_common.sh should be moved into another file to be sourced after arch_loaddef.

[MingcongBai]

Yes, I will do that as planned, just a minute.

[MingcongBai]

As mentioned in IRC, flag-dependent decisions in arch/_common.sh should be moved into another file to be sourced after arch_loaddef.

Just making sure, I will move the parts with

...
if ((AB_FLAGS_PIE)); then LDFLAGS_COMMON+='-fPIE -pie ' CFLAGS_COMMON+='-fPIE '; fi
if ((AB_FLAGS_SSP)); then CFLAGS_COMMON+='-fstack-protector-strong --param=ssp-buffer-size=4 '; fi
if ((AB_FLAGS_RRO)); then LDFLAGS_COMMON+='-Wl,-z,relro '; fi
if ((AB_FLAGS_NOW)); then LDFLAGS_COMMON+='-Wl,-z,now '; fi
...

To another file sourced after defines, right?

[Artoria2e5]

Yes. If there is any other logical decision that involves flag(s) changable by defines, move them too.

[MingcongBai]

Yes. If there is any other logical decision that involves flag(s) changable by defines, move them too.

Understood and clear.

[MingcongBai]

Issue fix on HEAD. Closing.