search

AOSC-Archive / autobuild3

AOSC OS package maintenance toolkit (version 3)
https://aosc.io
GNU General Public License v2.0
24 stars 17 forks source link

arch: noarch for data-only packages #89

Closed MingcongBai closed 8 years ago

MingcongBai commented 8 years ago

Currently Autobuild3 will not accept any data packages as architectural neutral, same for Java and other similar packages...

Well this should be done in a timely manner before more unnecessary work is done on future architectural ports.

Artoria2e5 commented 8 years ago

Allocate magic-arch NOARCH for $ABHOST

Artoria2e5 commented 8 years ago

Should work now. 6e2bd71, 9e8cea3, e5175eb.

# defines
ABHOST=NOARCH

Since defines is included after arch/ABHOST.sh, this actually won't cause NOARCH.sh to be loaded.

MingcongBai commented 8 years ago

Yep. https://github.com/AOSC-Dev/autobuild3/commit/9e8cea3bf0438b37285871f58fef17f416eb18b8 is starting to cause problem when building binutils on armel. Our armel uses quite a weird triplet as shown below. However it is by no mean a convention for binutils executables to be prefixed with host, with --host specified, binutils is assuming a cross build.

make[2]: armv7a-hardfloat-linux-gnueabi-ar: Command not found
MingcongBai commented 8 years ago

May I revert that commit to make it safe?

Artoria2e5 commented 8 years ago

It's not about noarch. The host decision is done in ABHOST/ABBUILD.

Use [[ $ABHOST != $ABBUILD ]] instead of [[ $HOST ]].

MingcongBai commented 8 years ago

That's why I mentioned https://github.com/AOSC-Dev/autobuild3/commit/9e8cea3bf0438b37285871f58fef17f416eb18b8 ...

MingcongBai commented 8 years ago

May I drop NOARCH as noarch... as it really looks bad as a part of a file name.

Artoria2e5 commented 8 years ago

I thought uppercase will make it look different and.. but yeah, it looks bad, so it's evil.

MingcongBai commented 8 years ago

Implemented and working. Closing.