Several merge-backs - Githubissues

AOSC-Archive / website-site-ng

Next-gen Community Portal

https://aosc.io/

6 stars 14 forks source link

Several merge-backs #80

Closed liushuyu closed 7 years ago

liushuyu commented 7 years ago

This change is

MingcongBai commented 7 years ago

@liushuyu

LionNatsu commented 7 years ago

I am not very clear about the testing system and the new mirror status monitor... Please feel free to merge when you think it is ready to merge.

BTW, @liushuyu, it maybe too long to be an issue... I will suggest that you may separate them into several branch by their functionalities next time.

(It says: "Pull requests that have a failing status can’t be merged on a phone." 🤣)

liushuyu commented 7 years ago

I am not very clear about the testing system and the new mirror status monitor... Please feel free to merge when you think it is ready to merge.

I was thinking it was a false-positive, but now I saw the links in RSS feed are all https://aosc.io/undefined. I'll get to fix this.

So, see, this is the use of testing system, although my tests are not very good, but still be able to figure out some problems

coveralls commented 7 years ago

Changes Unknown when pulling e04147bd4e3631b278335e8c32beb28437504a50 on liushuyu:develop into on AOSC-Dev:develop.

coveralls commented 7 years ago

Changes Unknown when pulling 0be707d9bddf125e1d0f187de30f85d09a7b5c33 on liushuyu:develop into on AOSC-Dev:develop.

liushuyu commented 7 years ago

Tests are passed despite the code check (need some kind of refactor to resolve the remaining problems), will merge this in 4 hours if there's no objections.

liushuyu commented 7 years ago

will merge this in 4 minutes if there's no objections.

coveralls commented 7 years ago

Changes Unknown when pulling e40d99998ba164bb9f32c99b6117313bf5a3627a on liushuyu:develop into on AOSC-Dev:develop.

Yexiaoxing commented 7 years ago

2 checks failed?

liushuyu commented 7 years ago

2 checks failed?

Only one now, it's the code style issue, can't be fixed unless a refactor is done.

coveralls commented 7 years ago

Changes Unknown when pulling e40d99998ba164bb9f32c99b6117313bf5a3627a on liushuyu:develop into on AOSC-Dev:develop.

liushuyu commented 7 years ago

Merged #80