Develop->Master Merge - Githubissues

AOSC-Archive / website-site-ng

Next-gen Community Portal

https://aosc.io/

6 stars 14 forks source link

Develop->Master Merge #81

Closed liushuyu closed 7 years ago

liushuyu commented 7 years ago

This change is

coveralls commented 7 years ago

Changes Unknown when pulling c59a6c794df6b98cd2e73f10228a82364916b1a9 on develop into on master.

liushuyu commented 7 years ago

Note: BitHound code style check relaxed, trivial errors are ignored now.

coveralls commented 7 years ago

Changes Unknown when pulling b963eb3bca287fee0b89a57a94600294cacc2492 on develop into on master.

liushuyu commented 7 years ago

All checks are passed, code coverage increased to 87%. Awaiting @LionNatsu to approve the changes to apply to master branch

coveralls commented 7 years ago

Changes Unknown when pulling 6de5c1ed7794e2594ced7d1007b9c9b0ef5245c1 on develop into on master.

liushuyu commented 7 years ago

I don't know if it's safe to assume the user who uses this page is using a(n) ES 2016 compatible browser, since let, arrow functions, and template literals are not supported in old browsers.

Of course I have considered these implementations but see I was just trying to figure out whether I should use them or not... Even user may use AOSC OS but that does not mean they will use something like Blink based or MozJS based browsers...

coveralls commented 7 years ago

Changes Unknown when pulling 79adc897cd744a77634b3c1a29d79c509e95a6ce on develop into on master.

coveralls commented 7 years ago

Changes Unknown when pulling b20135bd9d514ac226f93cd37c3acebdc9d81bfa on develop into on master.

LionNatsu commented 7 years ago

I don't know if it's safe to assume the user who uses this page is using a(n) ES 2016 compatible browser, since let, arrow functions, and template literals are not supported in old browsers.

Sorry, I didn't notice the path of script... Can you revert this...?

liushuyu commented 7 years ago

Sorry, I didn't notice the path of script... Can you revert this...?

Working on this, will rebase the repository to revert this commit partially.

coveralls commented 7 years ago

Changes Unknown when pulling b720d41e5786dffaa05e9400ffe606fe0b0df0d7 on develop into on master.

coveralls commented 7 years ago

Changes Unknown when pulling f81fbfc489c47adf546f01fdadb9ce75a3967f0f on develop into on master.

liushuyu commented 7 years ago

Merged #81