client assets: minify javascript - Githubissues

AOSC-Archive / website-site-ng

Next-gen Community Portal

https://aosc.io/

6 stars 14 forks source link

client assets: minify javascript #83

Closed liushuyu closed 7 years ago

liushuyu commented 7 years ago

@LionNatsu I don't know where hoverpanel is used. Seems like it is an extension of jQuery but never used by anything...?

BTW, GCL is used to minify the files, using the highest level of optimization, so I have patched one of the scripts to get GCL correctly minify the file.

This change is

coveralls commented 7 years ago

Coverage remained the same at 91.773% when pulling 14b4805effd6d967ffb99d2ca31e4a94d5890833 on develop into 8b52b20823735d54efdc01d46e2c4e4fa1b6d55b on master.

LionNatsu commented 7 years ago

@liushuyu You may delete hoverpanel.js... It has been removed from website .

coveralls commented 7 years ago

Coverage remained the same at 91.773% when pulling 34370f25c489e24e60d6d3058fa819bcdb403e00 on develop into 8b52b20823735d54efdc01d46e2c4e4fa1b6d55b on master.

coveralls commented 7 years ago

Coverage remained the same at 91.773% when pulling 3ea276966a548bb994e1e0f44edddaf0c7b1cd96 on develop into 8b52b20823735d54efdc01d46e2c4e4fa1b6d55b on master.

liushuyu commented 7 years ago

@LionNatsu Is it seem okay to you?

coveralls commented 7 years ago

Coverage remained the same at 91.773% when pulling 96b08950c9c37084106396ed70f1284b6666663b on develop into 8b52b20823735d54efdc01d46e2c4e4fa1b6d55b on master.

coveralls commented 7 years ago

Coverage remained the same at 91.773% when pulling d2b4a384bb1fd4fe471e5d8bb9ab83e8d277f1ca on develop into 8b52b20823735d54efdc01d46e2c4e4fa1b6d55b on master.

LionNatsu commented 7 years ago

The PR has mixed up many irrelevant commits so far. Deleting the hoverpanel one, fixing the mirror-status, fixing typos looks good to me. Maybe we should give it a cherry-pick into our develop branch.

However, I will say no to the minification due to the discussion you and me had before. In short, minifying manually will lead to something synchronisation problem between the normal one and the minified one. Moreover, to minify by cutting the functions may ruin Ajax calls. Closing. Please feel free to leave any comments or questions here, or reopen this if I was misunderstanding.