AOSC-Dev / aosc-os-abbs

ABBS/ACBS tree for AOSC OS package metadata, build configuration, scripts, and patches
https://packages.aosc.io
GNU General Public License v2.0
102 stars 80 forks source link

chromium, google-chrome: security update to 70.0.3538.110 #1420

Closed l2dy closed 5 years ago

l2dy commented 6 years ago

CVE IDs: CVE-2018-17462, CVE-2018-17463, CVE-2018-17464, CVE-2018-17465, CVE-2018-17466, CVE-2018-17467, CVE-2018-17468, CVE-2018-17469, CVE-2018-17470, CVE-2018-17471, CVE-2018-17472, CVE-2018-17473, CVE-2018-17474, CVE-2018-17475, CVE-2018-17476, CVE-2018-5179, CVE-2018-17477, CVE-2018-17478, CVE-2018-17479

Other security advisory IDs: ASA-201810-12

Descriptions: https://chromereleases.googleblog.com/2018/10/stable-channel-update-for-desktop.html This update includes 23 security fixes. https://chromereleases.googleblog.com/2018/11/stable-channel-update-for-desktop.html This update includes 3 security fixes. https://chromereleases.googleblog.com/2018/11/stable-channel-update-for-desktop_19.html This update includes 1 security fix.

Architectural progress:

MingcongBai commented 5 years ago

Having difficulty building on current stable:

../../chrome/browser/ui/views/omnibox/omnibox_text_view.cc: In function ‘void {anonymous}::ApplyTextStyleForType(SuggestionAnswer::TextStyle, OmniboxResultView*, gfx::RenderText*, const gfx::Range&)’:
../../chrome/browser/ui/views/omnibox/omnibox_text_view.cc:178:61: error: no match for ‘operator=’ (operand types are ‘{anonymous}::ApplyTextStyleForType(SuggestionAnswer::TextStyle, OmniboxResultView*, gfx::RenderText*, const gfx::Range&)::TextStyleNewAnswers’ and ‘<brace-enclosed initializer list>’)
       style = {part_color, .weight = gfx::Font::Weight::BOLD};
                                                             ^
../../chrome/browser/ui/views/omnibox/omnibox_text_view.cc:148:10: note: candidate: constexpr {anonymous}::ApplyTextStyleForType(SuggestionAnswer::TextStyle, OmniboxResultView*, gfx::RenderText*, const gfx::Range&)::TextStyleNewAnswers& {anonymous}::ApplyTextStyleForType(SuggestionAnswer::TextStyle, OmniboxResultView*, gfx::RenderText*, const gfx::Range&)::TextStyleNewAnswers::operator=(const {anonymous}::ApplyTextStyleForType(SuggestionAnswer::TextStyle, OmniboxResultView*, gfx::RenderText*, const gfx::Range&)::TextStyleNewAnswers&)
   struct TextStyleNewAnswers {
          ^~~~~~~~~~~~~~~~~~~
../../chrome/browser/ui/views/omnibox/omnibox_text_view.cc:148:10: note:   no known conversion for argument 1 from ‘<brace-enclosed initializer list>’ to ‘const {anonymous}::ApplyTextStyleForType(SuggestionAnswer::TextStyle, OmniboxResultView*, gfx::RenderText*, const gfx::Range&)::TextStyleNewAnswers&’
../../chrome/browser/ui/views/omnibox/omnibox_text_view.cc:148:10: note: candidate: constexpr {anonymous}::ApplyTextStyleForType(SuggestionAnswer::TextStyle, OmniboxResultView*, gfx::RenderText*, const gfx::Range&)::TextStyleNewAnswers& {anonymous}::ApplyTextStyleForType(SuggestionAnswer::TextStyle, OmniboxResultView*, gfx::RenderText*, const gfx::Range&)::TextStyleNewAnswers::operator=({anonymous}::ApplyTextStyleForType(SuggestionAnswer::TextStyle, OmniboxResultView*, gfx::RenderText*, const gfx::Range&)::TextStyleNewAnswers&&)
../../chrome/browser/ui/views/omnibox/omnibox_text_view.cc:148:10: note:   no known conversion for argument 1 from ‘<brace-enclosed initializer list>’ to ‘{anonymous}::ApplyTextStyleForType(SuggestionAnswer::TextStyle, OmniboxResultView*, gfx::RenderText*, const gfx::Range&)::TextStyleNewAnswers&&’
MingcongBai commented 5 years ago

Marking testing, waiting for LLVM 7 to land on stable.

l2dy commented 5 years ago

Move to 70.0.3538.102, adding CVE-2018-17478.

l2dy commented 5 years ago

Move to 70.0.3538.110, adding CVE-2018-17479.

https://chromereleases.googleblog.com/2018/11/stable-channel-update-for-desktop_19.html

MingcongBai commented 5 years ago

Fixed with https://github.com/AOSC-Dev/aosc-os-abbs/commit/2bfa6b30f233a2c1ed3e1d50dcd1f2868eb3a6a6. Closing.

l2dy commented 5 years ago

Use AOSA-2018-0449.