search

AOSC-Dev / aosc-os-abbs

ABBS/ACBS tree for AOSC OS package metadata, build configuration, scripts, and patches
https://packages.aosc.io
GNU General Public License v2.0
101 stars 80 forks source link

chntpw: switch to a fork, or a fork thereof #980

Closed Artoria2e5 closed 6 years ago

Artoria2e5 commented 6 years ago

The old chntpw is pretty much dead and useless, so people have been forking it to add features. rescatux's version adds helpful support for groups, and some more features are added by others forking their project. I guess we should switch to one of those offshoots for our package.

As a side note it would be great if AOSC could take over some of chntpw's development too. When I accidentally unlocked an admin account on a machine with Deep Freeze today, I was initially left with no means of re-locking the account as chntpw only flips the "DISABLED" bit off and no modifications in Windows would persist. I had to hack the source code to reverse its function. Perhaps we should just give users a way to set the entire bitfield to whatever they want.

https://github.com/AOSC-Dev/chntpw/releases/tag/v1.1

Artoria2e5 commented 6 years ago

I'll start with https://github.com/Googulator/chntpw, fork it over under AOSC-Dev (transfer it to my acct if you don't want it), and merge in some modifications from the original branch. Some libsam functions still need I/O pure cleanup.

Artoria2e5 commented 6 years ago

Ugh, let's not mix the debian patches into our repo. They just replicate all changes since 14xxxx.

Artoria2e5 commented 6 years ago

So the AOSC fork is pretty much ready now. Should I make a version tag for it?

MingcongBai commented 6 years ago

Sure, however... Are we sure that it's appropriate to basically set ourselves as a new upstream now? Or is there anyone we could contribute back to?

Artoria2e5 commented 6 years ago

Yeah, I guess so. Let me do some Makefile work before tagging though.

Artoria2e5 commented 6 years ago

Ah Bai, do you think I should make ntreg part of libsam or make them two different .so's? libsam depends on ntreg, but not the other way around.

MingcongBai commented 6 years ago

I mean if it's not breaking anything let's leave it...

Artoria2e5 commented 6 years ago

It's abso-fucking-lutely good to go now. I even fixed the make directives for that deprecated crypto part for setting passwords.

This is probably not surprising now, but it turns out those additions (sam*) are found in the official CD images too.

Artoria2e5 commented 6 years ago

Ugh. Upstreaming a fuckton of Debian patches.

Artoria2e5 commented 6 years ago

https://github.com/AOSC-Dev/chntpw/releases/tag/v1.1