search

AOSC-Dev / autobuild4

AOSC OS package maintenance toolkit (version 4)
GNU General Public License v2.0
6 stars 4 forks source link

[Core 12] arch/amd64: let the frame pointer return #17

Open MingcongBai opened 3 months ago

MingcongBai commented 3 months ago

Apologies for abruptly reverting that change but this change is best queued for Core 12 when we survey potential changes for core toolchains. cc @Artoria2e5 @jiegec

From original pull request:

https://www.brendangregg.com/blog/2024-03-17/the-return-of-the-frame-pointers.html argues that amd64 has enough registers to not be bothered by the FP. Google, Meta, Fedora, Ubuntu, and Arch seem to agree.

Should we follow suit? The main justification is that the FP gives real-time profiling tools a proper view of the stack.

MingcongBai commented 3 months ago

And, for the record, I second this change.

Artoria2e5 commented 3 months ago

Huh, I wasn't even aware that the original got merged. Must have slipped my mind…

MingcongBai commented 3 months ago

Huh, I wasn't even aware that the original got merged. Must have slipped my mind…

It was a gap in communication - I have noted that we should wait for Core 12 (i.e., in a month) before this change but only on Telegram. Sorry about that.