AOSC-Dev / ciel-rs

A tool for controlling AOSC OS packaging environments using multi-layer filesystems and containers (version 3)
MIT License
8 stars 5 forks source link

ciel-doctor: Request to add detection for EDITOR environment variable #11

Open CamberLoid opened 2 years ago

CamberLoid commented 2 years ago

When using zsh (shipped by our repository) as shell instead of distro's tarball-shipped bash without setting EDITOR environment variable, ciel will fail to call nano when performing configuration of source.list, resulting an unexpected exit. ciel doctor should notice the packager about the aforementioned issue.


An example log about this issue (without setting export EDITOR=nano)

root@Camber-AOSC-TestEnv /buildroot # ciel config -g
✔ Maintainer Information · Camber Huang<camber@aosc.io>
✔ Enable DNSSEC · no
✔ Edit sources.list · yes
error: Could not recognize the configuration.
1 root@Camber-AOSC-TestEnv /buildroot # /
130 root@Camber-AOSC-TestEnv /buildroot # ciel doctor
✓ Systemd D-Bus (systemd 248) seems to be working
✓ Basic I/O operations seem to be working
✓ Required binaries are correctly installed
✓ Filesystem support seems to be sufficient
✓ Environment seems sane (running in kvm)
✓ Disk I/O seems ok
✓ Disk space is sufficient (24.05GiB free of 31.87GiB).
root@Camber-AOSC-TestEnv /buildroot #