Add support for manually specifying architecture to `new` and `load-os`

AOSC-Dev / ciel-rs

A tool for controlling AOSC OS packaging environments using multi-layer filesystems and containers (version 3)

MIT License

8 stars 5 forks source link

Add support for manually specifying architecture to `new` and `load-os` #18

Closed Cyanoxygen closed 11 months ago

Cyanoxygen commented 1 year ago

With this PR users can now specify the target architecture when creating a Ciel workspace using ciel new, and when loading OS tarball using ciel load-os.

The target architecture specified is only used to determine what OS tarball to be downloaded automatically if the user chooses to let Ciel decide.
Supported architectures are hard-coded, so if AOSC OS ever introduces a new port, this should be updated.
If architecture is not specified when running ciel new, Ciel will ask the user for the desired target architecture.
If architecture is specified when running ciel new, Ciel will skip this question.
If any custom tarball is specified when running ciel load-os, Ciel will not ask for the target architecture.

Fixes #17.

Cyanoxygen commented 1 year ago

@Cyanoxygen Plus, when using custom tarballs, Ciel will not perform this check (likely, not tested).

Cyanoxygen commented 1 year ago

With existing Ciel workspaces (which does not have arch configured, Ciel will crash.

Cyanoxygen commented 1 year ago

@Cyanoxygen Plus, when using custom tarballs, Ciel will not perform this check (likely, not tested).

Cyanoxygen commented 1 year ago

I can load any OS I want by ciel load-os with the custom tarball, after manually running ciel init and ciel config -g.

Cyanoxygen commented 1 year ago

If running ciel new with a custom tarball, Ciel will still ask for target architecture - this is pending to be fixed, the desired behavior is to fallback to host architecture.

chenx97 commented 1 year ago

ciel new apparently fails to use tarballs located outside its workspace. It appears to skip the download yet still attempts to extract the empty archive prepared for downloading.

Cyanoxygen commented 1 year ago

ciel new apparently fails to use tarballs located outside its workspace. It appears to skip the download yet still attempts to extract the empty archive prepared for downloading.

I think this hsould be moved to a new issue.

Cyanoxygen commented 1 year ago

ciel new apparently fails to use tarballs located outside its workspace. It appears to skip the download yet still attempts to extract the empty archive prepared for downloading.

@chenx97 Please build against the latest commit and test it, this issue should be fixed with this commit.

Cyanoxygen commented 11 months ago

Review applied, please review the changes again.