search

AOSC-Dev / translations

Place to merge translations and prepare them for upstream
https://aosc.io/
13 stars 10 forks source link

improve peazip translation #21

Closed wbsdty331 closed 8 years ago

wbsdty331 commented 8 years ago

fixed transcode.

MingcongBai commented 8 years ago

Could you rebase your PR on the latest changes? My apologies.

jyhi commented 8 years ago

@MingcongBai rebase can also cause some problem.

MingcongBai commented 8 years ago

Should I reset here or...?

jyhi commented 8 years ago

@wbsdty331 Thanks for your contribution. Here are some problems we've found in your PR:

  1. .reg file must be encoded as GBK or GB18030. This PR changes it into UTF-8.
  2. chs.txt must be encoded as UTF-8 w/ BOM. This PR changes it into UTF-8 w/o BOM.
  3. Base is not the newest; some new fixes is made by @MingcongBai . You may first merge them into your changes.

Problem 1 and 2 can cause these localization files completely unusable. We suggest you to have a test first.

The following fixes in your PR are nice:

Since your changes are privided as 3 "big" commits, we're afraid that we cannot merge it at this moment. You can fix the problems talked above first.

MingcongBai commented 8 years ago

Or we can take the suggestion and thank him for it?

wbsdty331 commented 8 years ago

I will fix them as soon as possible.

MingcongBai commented 8 years ago

Thanks.