Closed Pietia10 closed 7 years ago
How is meant to work?
The code is in aosp KeyguardSecurityContainer.java
@B--B @MZO9400 @CheckYourScreen @xlxfoxxlx ... something to check here.
@Pietia10 This is the code... it is disabled by default: https://github.com/JDCTeam/android_frameworks_base/commit/13cb572a1a54f12fec1b82bcbe0254e2f4fcf120
Yeah in every phone this is enabled by default.
Looking on the code, if we set eg. 5 times, it will ask to factory reset the data... so you would like to have this?
True, doesn't work
It is meant to be so if disabled... as it is.
At least it should timeout. It doesn't timeout after 5 attempts
If countdown is > 0 ... yes... not if it is ==0
if (!(mMaxCountdownTimes > 0) && timeoutMs > 0) {
long deadline = mLockPatternUtils.setLockoutAttemptDeadline(
userId, timeoutMs);
handleAttemptLockout(deadline);
}
}
if (timeoutMs == 0) {
mSecurityMessageDisplay.setMessage(getWrongPasswordStringId(), true);
String msg = getMessageWithCount(getWrongPasswordStringId());
It works as it is set.
Weird
If it wont factory reset at some point the password will be easily bruteforceable , google know their's stuff .
My mistake... the commit I linked is on Opt-CM14 github...
This is on AOSP
Ah lol
Can we think to change this behaviour? Finally I use 99.99% the FP unlock...
And last: also LOS has this commit... https://github.com/LineageOS/android_frameworks_base/commit/13cb572a1a54f12fec1b82bcbe0254e2f4fcf120
FYI: if you fail for 5 times the FP recognition... the message that comes out is "Too much trials: retry later"... and you need to use the pin.
Not true with fp you just wait 30 seconda and try again .
What is not true?
You dont need to use pin after 5 failures of fp you just wait 30 seconds and you can use fp scanner again.
If you need to unlock the phone, you will wait 30 seconds, or you will swipe the correct pin to use the phone?
Anyway, the behaviour (as already written) is the same on LOS and all custom roms based on it. That's the situation.
The fingerprint implementation is same as in aosp however unlocking with passcode is not .
Are you referring to swipe passcode (3x3 or 4x4) or numeric keyboard with pin?
Im referring to both.
But numeric keyboard pin works!
https://www.dropbox.com/s/8qo0ltqznzl1xjx/Screenshot_20170528-172633.png?dl=0
(I hope italian language is not a problem to see)
Only swipe sequence has no timeout. Please check and confirm.
I cant reproduce what you sent me it doesnt work on my mi5 17 may build.
Fine... on our internal build, after 5 wrong pins or fingerprint, start the timeout of 30 seconds... on sequence swipe not. We will check what's happen... for next public build.
Thanks for reporting.
I found something: after a reboot, if you fail 5 times the sequence it stop with 30 sec delay. After entering the good sequence, the failing of 5 times do not generate anymore the 30 sec delay. To be checked...
Isnt a good idea to copy keyguard implementation from plain AOSP?
If you are trying to brute force a 6 pin code by swiping only few pins... you are playing with the phone, and you can stay for 2 hours trying to unlock a 6 pin code with 3 or 4 pins. If you wanna unlock you need 6 pin code... and after 5 trials with wrong 6 pins sequence the phone block with the timer of 30 seconds. Where is the security problem?
The issue do not exist, security it's fine. Closed.
Hi, There is a problem with password protection in ROM , (try submitting bad password five times) it simply does not work at all even though there are sources in aosp for that and it should be working . Phone mi5 latest stable