Closed dan-v closed 4 years ago
Note: I didn't exhaustively go through the full thing since the list is a lot bigger, but in general since it's most removals / additions to vendor-skip-files, as long as everything works we should be good.
There are also some differences between the built vendor/build.prop
and Google's vendor/build.prop
on crosshatch
(and likely others):
diff --git a/upstream/vendor/build.prop b/built/vendor/build.prop
index 9a767f3..5675f99 100644
--- a/upstream/vendor/build.prop
+++ b/built/vendor/build.prop
.....
#
# ADDITIONAL VENDOR BUILD PROPERTIES
#
ro.build.expect.bootloader=b1c1-0.3-6623201
ro.build.expect.baseband=g845-00107-200702-B-6648703
+ro.carrier=unknown
+ro.config.notification_sound=OnTheHunt.ogg
+ro.config.alarm_alert=Alarm_Classic.ogg
ro.apex.updatable=true
keyguard.no_require_sim=true
ro.control_privapp_permissions=enforce
@@ -138,15 +141,3 @@ aaudio.hw_burst_min_usec=2000
ro.bluetooth.a2dp_offload.supported=true
persist.bluetooth.a2dp_offload.disabled=false
persist.bluetooth.a2dp_offload.cap=sbc-aac-aptx-aptxhd-ldac
-ro.hardware.vulkan=adreno
-ro.hardware.egl=adreno
-vendor.power.pasr.enabled=true
-ro.boot.vendor.overlay.theme=com.android.internal.systemui.navbar.twobutton
-drm.service.enabled=true
-media.mediadrmservice.enable=true
-ro.com.android.prov_mobiledata=false
-ro.storage_manager.enabled=true
-ro.carrier=unknown
-ro.config.notification_sound=OnTheHunt.ogg
-ro.config.alarm_alert=Alarm_Classic.ogg
At the very least, we should probably set ro.hardware.vulkan
and ro.hardware.egl
in PRODUCT_PROPERTY_OVERRIDES
like is done in taimen/walleye
I took another spin through these devices and added system_ext. I didn't quite get a chance to get to sunfish tonight.
lib/hw/sensors.<device>.so
and lib64/hw/sensors.<device>.so
.Need to deal with the system property differences that are specific to devices but this is a good start.
drm.service.enabled=true
This controls whether DRM is supported. It should be up to the OS.
media.mediadrmservice.enable=true
This controls whether proper secure buffers are supported so that the sandbox can be used. This should probably be enabled by android-prepare-vendor, rather than the OS. It doesn't enable DRM but rather sandboxing it securely if it's enabled.
Going to file a separate issue about system properties.
Going to merge this since it's a lot better than the current state. Can handle any issues as follow-up.
Dan, would you mind just diffing the config.json for
And making sure they're sycned up / the diff looks sane. For the first three I don't think there really would be any changes.