search

AOSPAlliance / android-prepare-vendor

Set of scripts to automate AOSP compatible vendor blobs generation from factory images
25 stars 8 forks source link

add missing system properties for each device #27

Open thestinger opened 4 years ago

thestinger commented 4 years ago

System properties should be compared for each device, and then each missing system property needs to be investigated. The ro.hardware.vulkan and ro.hardware.egl properties should definitely be added.

The media.mediadrmservice.enable property (see frameworks/av/media/libstagefright/omx/OMXNodeInstance.cpp) should be added to enable sandboxing DRM if it's enabled.

DRM being enabled seems to be controlled by drm.service.enabled (see frameworks/av/drm/libdrmframework/DrmManagerClientImpl.cpp). This should probably be left up to the OS to enable it. There may be other toggles to control whether it's enabled. I'm not sure.

I'm unsure what vendor.power.pasr.enabled does, if anything. It seems that if it does do something, it's internal to vendor, not something in the AOSP source tree at this time. Could grep for it in vendor.img and perhaps check in CAF.

The ro.com.android.prov_mobiledata might as well match the stock OS but note that the code reading it defaults to false anyway.

The ro.storage_manager.enabled property doesn't really seem specific to devices and should probably be left up to the OS. It doesn't do much useful without the Play services portion of the code anyway.

chirayudesai commented 4 years ago

re: pasr : from a quick look there's a pasr HAL, vendor.qti.power.pasrmanager@1.0.so

We do include it, but it looks like it might not be defined anywhere / actually used / could just be a CAF leftover