search

AOSPAlliance / android-prepare-vendor

Set of scripts to automate AOSP compatible vendor blobs generation from factory images
25 stars 8 forks source link

Add missing sargo API-29 permission files #39

Closed CaseyBakey closed 3 years ago

CaseyBakey commented 3 years ago

During the Android 9 -> 10 update, some apps were moved from /system to /product or /vendor and thus new permission files were needed on these partitions. Here there are.

CaseyBakey commented 3 years ago

I forgot these permission files last time...so the build did pass, but the device was stuck on Android logo because of priv-app permission whitelisting errors.

Today I did a clean AOSP build for Pixel 3a/sargo, from scratch using my branch. Opengapps were added during the build. The device was able to boot and was able to use Google Play Store to download and install app, indicating the Opengapps were working and so the full configuration for API-29 sargo.

chirayudesai commented 3 years ago

Hi, could you reword the commit message to be more like

"sargo: full: Add missing permission files" to be clearer, so that it's easier to see just by the message.

Also these could be both in the same PR, and even the same commit. just write it as "bonito/sargo" or "b4s4" as google calls them. that's fine too!

You can force-push to the branch on your github to update an existing PR without opening a new one.