search

AOSPAlliance / android-prepare-vendor

Set of scripts to automate AOSP compatible vendor blobs generation from factory images
25 stars 8 forks source link

Extract APN list from CarrierSettings #45

Closed mikeNG closed 3 years ago

mikeNG commented 3 years ago

Fixes #28

Requires a change in platform/build to prevent copying the AOSP sample APN list. Here's my proposed commit for CalyxOS: https://review.calyxos.org/c/CalyxOS/platform_build/+/584

mikeNG commented 3 years ago

Note: only tested on sargo & android 10, checking android 11 and the rest of the devices would be appreciated

dan-v commented 3 years ago

@mikeNG this change looks good to me. @daradib - curious if you have any thoughts on this change?

chirayudesai commented 3 years ago

Converted to draft pending a test run, might need updates for Pixel 2

chirayudesai commented 3 years ago

This is fine on 10.

A quick test on 11 would be appreciated. If you don't pick the build/make change linked the apn file here would just get ignored.

@mikeNG was looking into CarrierConfig overlay as well, but the vendor.xml mostly points to com.google.android.ims which might rely on gapps and thus can't be put into naked.

chirayudesai commented 3 years ago

Works. All devices build, and generated apns file looks good too.

thestinger commented 3 years ago

This doesn't work with AOSP even with the standard APN configuration copying disabled. Maybe it has to do with the vendor file whitelist feature. Regardless, it doesn't work.

thestinger commented 3 years ago

Also, worth noting that they let many of the apps in the factory images get outdated and update them via the Play Store. We need to check if there's an update to this app being served via the Play Store and use that instead.

thestinger commented 3 years ago

It's possible that this is not actually device-specific beyond the version of the app that's bundled, and should actually be handled outside of android-prepare-vendor by extracting this from the latest version of the app and replacing the APNs in AOSP.