search

AOSPAlliance / android-prepare-vendor

Set of scripts to automate AOSP compatible vendor blobs generation from factory images
24 stars 8 forks source link

Wrong parameter name "--img" in the help #55

Closed Jim-Bar closed 3 years ago

Jim-Bar commented 3 years ago

The true parameter name is --imgs. Changed the help to reflect that.

Note that this error is also present on the branch android10.

chirayudesai commented 3 years ago

I think we should fix the code instead, img seems right.

i.e. https://github.com/CIS-Mobile/android-prepare-vendor/commit/66fa2497c5e9e8ea8de17112e9d33e9784527c08

Jim-Bar commented 3 years ago

Problem with that is that it will break the workflow of people already using --imgs.

chirayudesai commented 3 years ago

Good point, then we can just keep both around anyway (i.e. -i|-img|--imgs) but still document only -i/--img for consistency?

chirayudesai commented 3 years ago

Good point, then we can just keep both around anyway (i.e. -i|-img|--imgs) but still document only -i/--img for consistency?

Done. https://github.com/AOSPAlliance/android-prepare-vendor/pull/68