Don't put date in the generated makefiles

AOSPAlliance / android-prepare-vendor

Set of scripts to automate AOSP compatible vendor blobs generation from factory images

25 stars 8 forks source link

Don't put date in the generated makefiles #61

Closed chirayudesai closed 3 years ago

chirayudesai commented 3 years ago

We talk about reproducibility and this is one thing that keeps changing even when everything else doesn't.

chirayudesai commented 3 years ago

Fired off a build at https://github.com/AOSPAlliance/vendor_google_devices/actions/runs/679592146

That will remove the date from all current files.

I'll fire off another build once done, and with that we can verify reproducibility, sort of (since it'd still be the same host, even if it's different clean runs)

chirayudesai commented 3 years ago

https://github.com/AOSPAlliance/vendor_google_devices/pull/24

This removes the date.

One more run to follow which should have no changes at all.

chirayudesai commented 3 years ago

Works, https://github.com/AOSPAlliance/vendor_google_devices/runs/2202139010?check_suite_focus=true - it didn't create a PR because the git diff was empty.

It's reproducible*!

Technically not since carriersettings-extractor fetches a file from AOSP master which gets updates from time to time but that's an easy fix if ever needed.