search

AOSPAlliance / android-prepare-vendor

Set of scripts to automate AOSP compatible vendor blobs generation from factory images
24 stars 8 forks source link

download-nexus-image: Use HTTP 1.1 #64

Closed chirayudesai closed 3 years ago

chirayudesai commented 3 years ago

curl: (92) HTTP/2 stream 0 was not closed cleanly: PROTOCOL_ERROR (err 1)

https: //github.com/curl/curl/issues/3206 Change-Id: I6374b41361e61259941cc9e3c4863af918ec44ce

chirayudesai commented 3 years ago

This usually happened when you re-ran apv after a full download / run was complete.

Workaround done is as mentioned in the linked curl issue as they deemed this to be a server side issue.

dan-v commented 3 years ago

not entirely sure this will fix the problem depending on what version of curl this flag was added and what version is default on something like ubuntu 18.04

chirayudesai commented 3 years ago

not entirely sure this will fix the problem depending on what version of curl this flag was added and what version is default on something like ubuntu 18.04

It has worked well here so far, both for working with existing archives and downloading new releases.

https://packages.ubuntu.com/bionic/curl tells me bionic (18.04) has curl 7.58.0, xenial (16.04) has 7.47.0

https://github.com/curl/curl/blob/master/docs/cmdline-opts/http1.1.d says this option was added in curl 7.33.0 so we should be fine.