Pixels: Add CarrierConfigOverlay to rro_overlays

chirayudesai commented 3 years ago

Will also need a

PRODUCT_SOONG_NAMESPACES += vendor/google_devices/$device in the device trees to work.

Depends on https://github.com/AOSPAlliance/android-prepare-vendor/pull/65

chirayudesai commented 3 years ago

Fired off a run after merging #66 to make sure it doesn't make a difference without this commit.

https://github.com/AOSPAlliance/vendor_google_devices/runs/2390496817?check_suite_focus=true

@danielfullmer you mind taking a look as well? Thanks!

Edit: Failed with out of disk space :(

sdh4 commented 3 years ago

Confirmed that the build succeeds and seems to give a fully functional phone on redfin (Verizon/US full config incl. VOLTE) with these changes (with minor adjustment applied below).

It would probably be a good idea to document the PRODUCT_SOONG_NAMESPACES requirement somewhere (perhaps in the front page README)
There's a bit of inconsistency in the full configuration entries in this patch. I used "rro-overlays": [] instead of the "rro-overlays": [""] given here for redfin or "rro-overlays": "" given here for bramble.
Without this commit the APV run fails because it searches for rro-overlays entries which are otherwise missing.

AOSPAlliance / android-prepare-vendor

Pixels: Add CarrierConfigOverlay to rro_overlays #67