Open chirayudesai opened 4 years ago
We initially had this forked on GitLab while it was work in progress, and at this point I'm a lot more familiar with that so that's what we have setup https://github.com/AOSPAlliance/device-flasher/blob/master/.gitlab-ci.yml - that can serve as a reference.
Basically, we run go fmt
to ensure the formatting is sane, especially for PRs.
And make
to build it for all platforms on Linux
Looks like GitHub supports macOS and Windows going by https://github.com/mvdan/github-actions-golang - so maybe what we can do is have both, since I think for the release builds atleast at the moment it'd be nicer to compile them all on Linux / one platform rather than have it compile on three different platforms.
Also not sure about how artifacts would work here.
Latest on GitLab looks like https://gitlab.com/calyxos/device-flasher/-/jobs/770472631/artifacts/browse
For the release tag 1.0.1 I compiled the binaries myself on ArchLinux, go version go1.15.2 linux/amd64
Reference: https://github.com/AOSPAlliance/device-flasher/blob/master/.gitlab-ci.yml
go fmt
, especially for PRsmake
, to just re-use the existing script to build all the variants