search

AOSSIE-Org / Agora-Android

Mirror of the Agora-Android Project
https://gitlab.com/aossie/agora-android
GNU General Public License v3.0
15 stars 45 forks source link

Gsoc 2023 migrating main activity to compose #62

Closed narendraanjana09 closed 1 year ago

narendraanjana09 commented 1 year ago

Fixes #61

Changes :
Migrated Main Activity to Compose, Added new Top App Bar, Bottom Nav Bar and fixed few bug fixes along it.
Previous UI:
image


New UI ScreenShot
image


New UI Screen recording:
https://drive.google.com/file/d/1cWChlhjyOEiJxzEtVAC4zJVvGf_dCDiW/view?usp=drivesdk


Appetize App Link
https://appetize.io/app/d7wqeezvl3ynuojmq2fgpxgow4?device=pixel4&osVersion=11.0&scale=75

hackeramitkumar commented 1 year ago

@narendraanjana09 You have to resolve conflicts..

narendraanjana09 commented 1 year ago

@narendraanjana09 You have to resolve conflicts.. resolved.

hackeramitkumar commented 1 year ago

@narendraanjana09 rebase it..

narendraanjana09 commented 1 year ago

@narendraanjana09 rebase it..

done

hackeramitkumar commented 1 year ago

@narendraanjana09 rebase it...

narendraanjana09 commented 1 year ago

@narendraanjana09 rebase it...

done

hackeramitkumar commented 1 year ago

@narendraanjana09 this is our last pr for the jetpack compose migration. So now you have to fix the linting.

hackeramitkumar commented 1 year ago

gradlew ktlintcheck -p

Run this command locally and fix the issues.

narendraanjana09 commented 1 year ago

gradlew ktlintcheck -p

Run this command locally and fix the issues.

I have tried it before but it seems to me that issue is not here actually out actions ci file is not able to read our secrets thus unable to assign values to variables in build file which leads to non-null error.